Load Contexts in Analyser via entry points#763
Merged
Conversation
tieneupin
added
bug
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
==========================================
- Coverage 49.46% 49.31% -0.16%
==========================================
Files 92 92
Lines 9793 9815 +22
Branches 1283 1296 +13
==========================================
- Hits 4844 4840 -4
- Misses 4709 4725 +16
- Partials 240 250 +10 🚀 New features to boost your workflow:
|
src/murfey/client/analyser.py
Outdated
| self._murfey_config, | ||
| self._token, | ||
| ) | ||
| if context := _get_context("SPAMetadataContext"): |
Contributor
There was a problem hiding this comment.
Should there be a None catch here?
Contributor
Author
There was a problem hiding this comment.
I've set it to continue if None is returned.
src/murfey/client/analyser.py
Outdated
| self._murfey_config, | ||
| self._token, | ||
| ) | ||
| if context := _get_context("TomographyMetadataContext"): |
Contributor
There was a problem hiding this comment.
Also None catch here?
…n of the Analyser class
stephen-riggs
approved these changes
Mar 24, 2026
Contributor
stephen-riggs
left a comment
stephen-riggs
left a comment
There was a problem hiding this comment.
Thanks for fixing the previous comments, looks good now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have reached a point in Murfey's development where some of the Context classes that can be attached to Murfey's Analyser class require additional dependencies not present in the default installation. To keep the client-side installation as lean as possible, we need to break the import chain by not importing all the Context classes upon initialisation of the Analyser. They should only be imported and attached to the Analyser once file analysis has determined which Context is needed for that particular session.
This PR accomplishes this by setting up the Context classes as entry points and loading the appropriate one once the Analyser has identified the appropriate context for the workflow.